From 7840ab66a5cf754e2325ce269c0134ad8aff5b6b Mon Sep 17 00:00:00 2001 From: Nils Knappmeier Date: Fri, 15 Mar 2019 22:39:36 +0100 Subject: [PATCH 1/2] test: make security testcase internet explorer compatible Internet Explorer does not support the 'class Testclass {}' notation, and tests are not compiled using babel. closes #1497 --- spec/security.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/spec/security.js b/spec/security.js index 45b96c34b..12b96e629 100644 --- a/spec/security.js +++ b/spec/security.js @@ -11,11 +11,16 @@ describe('security issues', function() { }); it('should allow prototype properties that are not constructors', function() { - class TestClass { - get abc() { + function TestClass() { + } + + Object.defineProperty(TestClass.prototype, 'abc', { + get: function() { return 'xyz'; } - } + + }); + shouldCompileTo('{{#with this as |obj|}}{{obj.abc}}{{/with}}', new TestClass(), 'xyz'); }); From 684f1032c62758d1cb548d4ff9e7582a6554d313 Mon Sep 17 00:00:00 2001 From: Nils Knappmeier Date: Fri, 15 Mar 2019 22:49:36 +0100 Subject: [PATCH 2/2] chore: reactivate saucelabs-tests --- Gruntfile.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gruntfile.js b/Gruntfile.js index ff89c737d..838e7b395 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -229,7 +229,7 @@ module.exports = function(grunt) { grunt.task.loadTasks('tasks'); grunt.registerTask('bench', ['metrics']); - grunt.registerTask('sauce', [] /* process.env.SAUCE_USERNAME ? ['tests', 'connect', 'saucelabs-mocha'] : [] */); + grunt.registerTask('sauce', process.env.SAUCE_USERNAME ? ['tests', 'connect', 'saucelabs-mocha'] : []); grunt.registerTask('travis', process.env.PUBLISH ? ['default', 'sauce', 'metrics', 'publish:latest'] : ['default']);