Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates with multiple raw-blocks broken in 4.4.4 #1579

Closed
nknapp opened this issue Oct 20, 2019 · 0 comments
Closed

templates with multiple raw-blocks broken in 4.4.4 #1579

nknapp opened this issue Oct 20, 2019 · 0 comments
Milestone

Comments

@nknapp
Copy link
Collaborator

@nknapp nknapp commented Oct 20, 2019

I just introduced this bug in 4.4.4, I'm sorry.
Templates like {{{{identity}}}}abc{{{{/identity}}}} {{{{identity}}}}abc{{{{/identity}}}}
(with identity being a block-helper that just returns the block contents) will return abc{{{{/identity}}}} {{{{identity}}}}abc instead of abc abc.

@nknapp nknapp added this to the 4.4.5 milestone Oct 20, 2019
nknapp added a commit that referenced this issue Oct 20, 2019
In 4.4.4 the block-contents was matched with an eager match, which means
that with multiple raw-blocks of the same kind, the block was spanned
over the first ending-tag until the last one.
This commit replaces this by a non-eager match.

closes #1579
nknapp added a commit that referenced this issue Oct 20, 2019
In 4.4.4 the block-contents was matched with an eager match, which means
that with multiple raw-blocks of the same kind, the block was spanned
over the first ending-tag until the last one.
This commit replaces this by a non-eager match.

closes #1579
@nknapp nknapp closed this in 8d5530e Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.