Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property 'VERSION' does not exist on type 'typeof Handlebars' #1647

Closed
leosdad opened this issue Jan 27, 2020 · 5 comments
Closed

Property 'VERSION' does not exist on type 'typeof Handlebars' #1647

leosdad opened this issue Jan 27, 2020 · 5 comments

Comments

@leosdad
Copy link

@leosdad leosdad commented Jan 27, 2020

Hi,

Just a simple request. When calling handlebars.VERSION, the error message Property 'VERSION' does not exist on type 'typeof Handlebars' appears when using Typescript. I believe this is just a simple fix in the index.d.ts file. Thanks.

@nknapp
Copy link
Collaborator

@nknapp nknapp commented Jan 28, 2020

Can you open a PR for that? Please also include a test in test.ts . It would also be nice to have the documentation updated (the API reference on handlebarsjs.com) to include this feature.

@papasmile
Copy link
Contributor

@papasmile papasmile commented Feb 4, 2020

Hi, sorry, how do you run tests in test.ts anyway? Just running npm test doesn't seem to include any output from that file...

@nknapp
Copy link
Collaborator

@nknapp nknapp commented Feb 4, 2020

npm run check-before-pull-request should include the tests. Otherwise, run npm run dtslint

@nknapp
Copy link
Collaborator

@nknapp nknapp commented Feb 5, 2020

published in 4.7.3

@leosdad
Copy link
Author

@leosdad leosdad commented Feb 5, 2020

published in 4.7.3

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.