Resolve deprecation warning message from eslint while running eslint #1586
I followed this Migrating to v2.0.0 to update the configuration as per the recommendation which fixed the deprecation message.
Before creating a pull-request, please check https://github.com/wycats/handlebars.js/blob/master/CONTRIBUTING.md first.
Generally we like to see pull requests that
There was a DeprecationWarning message from eslint saying that `ecmaFeatures` property has been deprecated. Moved it under the `parserOptions` as per recommended here - https://eslint.org/docs/user-guide/migrating-to-2.0.0.
The comment in the eslint config indicates that not all es6 features should be enabled.
Object.assign for example does not work in IE and we don't use polyfills.
Its a good thing to fix the config. Could you do it so that the list of features is used again?
It would also be helpful to have the disable es6-language at all for the files in the
It has happend a couple of times that I wrote a test and everything was find when I ran the tests locally. But when they were executed in SauceLabs with IE11, there was an error.
It doesn't have to be in this PR, but it is something to keep in mind.
Actually, they aren't being removed; but it's just that explicitly setting them under
So, that being said there isn't actually any change done in the config. These are default features of Ecma Script that eslint already knows once you set the version now. Check this:
Also, as per the deprecation warning - even if you do set them it has no effect now.
Let me know your thoughts on this.