Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch cmd parser to latest minimist #1672

Merged
merged 2 commits into from Apr 3, 2020
Merged

Switch cmd parser to latest minimist #1672

merged 2 commits into from Apr 3, 2020

Conversation

dougwilson
Copy link
Contributor

@dougwilson dougwilson commented Apr 3, 2020

This pull request just swaps the command line parser to the latest version of minimist, which removes a couple of "regressions" (like the changed description of version and the changed position of the help option), but mainly both (1) removes the minimist security notice and (2) keeps the 4.x on the same Node.js version support plan.

I hope this pull request can be considered.

@dougwilson
Copy link
Contributor Author

@dougwilson dougwilson commented Apr 3, 2020

Travis CI status did not update on the pull request, but here is a link to the passing Travis CI build: https://travis-ci.org/github/wycats/handlebars.js/builds/670392714

@ErisDS
Copy link
Collaborator

@ErisDS ErisDS commented Apr 3, 2020

Will take a look ASAP

@aorinevo
Copy link
Contributor

@aorinevo aorinevo commented Apr 3, 2020

Happy to take this out for a spin :)

@dougwilson
Copy link
Contributor Author

@dougwilson dougwilson commented Apr 3, 2020

This also fixes #1673

@ErisDS
Copy link
Collaborator

@ErisDS ErisDS commented Apr 3, 2020

Just to let you know, I am looking to merge and release this. I would prefer to do the node changes separately as a revert though.

I then plan to revert this change on the master branch because (as you said on twitter) the yargs changes are slightly more maintainable long term.

This would leave us with #1673 on master, but I've found a fix for that.

@ErisDS
Copy link
Collaborator

@ErisDS ErisDS commented Apr 3, 2020

I've pushed the change to split out the node changes to the PR which also has the side effect of getting the travis build to show here properly.

@ErisDS ErisDS merged commit c2f1e62 into handlebars-lang:4.x Apr 3, 2020
2 checks passed
@ErisDS
Copy link
Collaborator

@ErisDS ErisDS commented Apr 3, 2020

4.7.6 is out and will hopefully solve all the issues. Thanks for taking the time to provide a solution to this tricky situation ❤️.

Here's to hoping that the overbearing package security system that is the root cause gets under control soon 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants