New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/node: use an address object in the coin address endpoint [bugfix] #44

Merged
merged 1 commit into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@turbomaze
Contributor

turbomaze commented Aug 8, 2018

The coin address endpoint at ./lib/node/http.js passes an address string to this.node.getCoinsByAddress(*), which eventually passes that same address to the mempool's getCoinsByAddress(*). Attempting to query an address from the CLI or from CURL via hsd-cli coin $ADDRESS results in the error message object is not an address.

This PR creates an Address object after receiving the address string to fix this issue.

@turbomaze turbomaze changed the title from [bugfix] use an address object in the coin address endpoint to lib/node: use an address object in the coin address endpoint [bugfix] Aug 8, 2018

@boymanjor

This comment has been minimized.

Show comment
Hide comment
@boymanjor

boymanjor Sep 7, 2018

Contributor

Sorry it took a while to get to this. LGTM.

Contributor

boymanjor commented Sep 7, 2018

Sorry it took a while to get to this. LGTM.

@boymanjor boymanjor merged commit 60f258e into handshake-org:master Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment