Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when select side menu item than canter view issue #72

Closed
test-ineed opened this issue Feb 1, 2018 · 4 comments
Closed

when select side menu item than canter view issue #72

test-ineed opened this issue Feb 1, 2018 · 4 comments
Labels

Comments

@test-ineed
Copy link

simulator screen shot - iphone 6 - 2018-01-31 at 12 50 13
simulator screen shot - iphone 6 - 2018-01-31 at 12 50 19
simulator screen shot - iphone 6 - 2018-01-31 at 12 50 24

@test-ineed
Copy link
Author

it's only happen in iOS 11 and above

@test-ineed
Copy link
Author

using safe area.

@enmiller
Copy link
Contributor

enmiller commented Feb 9, 2018

@test-ineed
There appears to be a critical range with the contentScale property of the TransitionOptions that causes the odd behavior. When using a contentScale of 0.87 - 0.90, there seems to be an issue with the content controller's view not getting its safeAreaInsets set properly. From testing, I can only see it affecting those four values in that range.

I will continue to look into the issue but, for now, I will update the default value of the contentScale to be outside of this range so that the library works on iOS 11 by default

For now, you can change the transitionOptions to be outside of that range and you should see things improve.

@enmiller enmiller added the bug label Feb 9, 2018
@enmiller
Copy link
Contributor

enmiller commented Feb 9, 2018

@test-ineed
Try using 2.2.1. The default contentScale was changed to be outside of the affected range that causes the safeAreaInsets not to be set properly on the content controller.

I will still be looking into this issue to see how I can make things work no matter the contentScale setting but this is the best I can do for now.

@enmiller enmiller closed this as completed Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants