Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column sort indicator does not update for setSortConfig server-side sorting #19

Closed
s1monj opened this Issue Dec 12, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@s1monj
Copy link

s1monj commented Dec 12, 2018

Description

Following this example:
https://handsontable.com/docs/6.2.1/ColumnSorting.html#setSortConfig

If indicator is set to true and server-side sorting is used in beforeColumnSort with setSortConfig and return false, the indicator should update accordingly.

Steps to reproduce

  1. https://handsontable.com/docs/6.2.1/ColumnSorting.html#setSortConfig

Demo

https://jsfiddle.net/w5qymdbc/

Your environment

  • Handsontable version: 6.2.1
  • Browser Name and version: Chrome 71
  • Operating System: Linux
@wojciechczerniak

This comment has been minimized.

Copy link
Member

wojciechczerniak commented Dec 13, 2018

setSortConfig does not update the view. We need to call this.render(). Updated demo: https://jsfiddle.net/w5qymdbc/1/

We're missing a line in our documentation. Sorry for that.

Edit: this.loadData() does the this.render() that's why it's missing. But we should make it clear in the docs.

@wojciechczerniak wojciechczerniak transferred this issue from handsontable/handsontable Dec 13, 2018

@wszymanski

This comment has been minimized.

Copy link
Member

wszymanski commented Dec 13, 2018

Hey, @s1monj.

Thank you for your effort. We have done that in this way, because we want to give the ability to decide if view should be re-rendered.

I updated documentation of snippet. I hope that it will be yet more clear. This change will be released with new Handsontable.

@wszymanski wszymanski referenced this issue Dec 13, 2018

Merged

Docs update #5666

@wojciechczerniak wojciechczerniak added this to the January 2019 milestone Dec 13, 2018

wszymanski added a commit to handsontable/handsontable that referenced this issue Dec 14, 2018

@wszymanski wszymanski closed this Dec 14, 2018

@AMBudnik

This comment has been minimized.

Copy link

AMBudnik commented Mar 6, 2019

Hey @s1monj

I'm pleased to inform that we've solved the issue. The fixed version is 7.0.0.

Again, thank you for the feedback!

@AMBudnik AMBudnik added the bug label Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.