Skip to content
This repository has been archived by the owner on Jul 3, 2019. It is now read-only.

Add tests for bottom overlay scroll synchronization #96

Merged
merged 2 commits into from Jul 25, 2018
Merged

Add tests for bottom overlay scroll synchronization #96

merged 2 commits into from Jul 25, 2018

Conversation

budnix
Copy link
Member

@budnix budnix commented Jul 18, 2018 •
edited

Context

This PR add additional tests for fixed bottom overlay synchronization which was fixed in this PR.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issue(s):

  1. Add missing .scrollLeft assignment to the bottom-left overlay handsontable#5269

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation.

@budnix budnix requested a review from wszymanski July 18, 2018 13:02
@budnix budnix mentioned this pull request Jul 18, 2018
Merged
6 tasks
wszymanski
wszymanski previously approved these changes Jul 25, 2018
View reviewed changes
@wszymanski wszymanski assigned budnix and unassigned wszymanski Jul 25, 2018
@budnix budnix merged commit e1e1a53 into develop Jul 25, 2018
@budnix budnix deleted the feature/ce-5163 branch July 25, 2018 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wszymanski wszymanski wszymanski approved these changes

Assignees

@budnix budnix

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@budnix @wszymanski