Skip to content
This repository has been archived by the owner. It is now read-only.

ESLINT - prefer-rest-params #127

Merged
merged 2 commits into from Aug 30, 2018

Conversation

@swistach
Copy link
Member

commented Aug 29, 2018

Context

Necessary changes to remove prefer-rest-params from our custom .eslintrc.

How has this been tested?

  1. npm run lint
  2. should be error-free

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. #107

@swistach swistach added this to the September 2018 milestone Aug 29, 2018

@swistach swistach requested a review from wszymanski Aug 29, 2018

@swistach swistach requested review from pnowak and removed request for wszymanski Aug 30, 2018

@swistach swistach assigned pnowak and unassigned wszymanski Aug 30, 2018

@pnowak
pnowak approved these changes Aug 30, 2018
Copy link
Member

left a comment

LGFM

@pnowak pnowak assigned swistach and unassigned pnowak Aug 30, 2018

@swistach swistach merged commit 559b619 into develop Aug 30, 2018

4 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (budnix) No manifest changes detected

@swistach swistach deleted the feature/eslint-prefer-rest-params branch Aug 30, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.