Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hooks to the hiddenRows and hiddenColumns plugins. #165

Closed
wants to merge 6 commits into
base: develop
from

Conversation

Projects
None yet
3 participants
@jansiegel
Copy link
Member

jansiegel commented Oct 18, 2018

Add the following hooks:

  • beforeHideRows
  • afterHideRows
  • beforeUnhideRows
  • afterUnhideRows
  • beforeHideColumns
  • afterHideColumns
  • beforeUnhideColumns
  • afterUnhideColumns
    #163
Add the following hooks:
- beforeHideRows
- afterHideRows
- beforeUnhideRows
- afterUnhideRows
- beforeHideColumns
- afterHideColumns
- beforeUnhideColumns
- afterUnhideColumns
 #163
@AMBudnik

This comment has been minimized.

Copy link
Contributor

AMBudnik commented Oct 18, 2018

I'm so happy to see this PR @jansiegel !

@wszymanski wszymanski assigned jansiegel and unassigned wszymanski Oct 19, 2018

@wszymanski

This comment has been minimized.

Copy link
Member

wszymanski commented Oct 19, 2018

Please add extra test related to not calling after... hook when before... hook return false.

@jansiegel jansiegel assigned wszymanski and unassigned jansiegel Oct 24, 2018

@wszymanski wszymanski assigned jansiegel and unassigned wszymanski Oct 31, 2018

jansiegel added some commits Nov 9, 2018

- Make the plugin still run the 'after' hooks for hiding/unhiding row…
…s/columns, if the validation was unsuccessful

- Add an additional parameter to the 'after' hooks, telling if the validation was successful
 #163

@jansiegel jansiegel assigned wszymanski and unassigned jansiegel Nov 9, 2018

* @param {Array} columns Array of column indexes.
*/
isColumnDataValid(columns) {
const outOfBounds = columns.find(column => (column < 0 || column > this.hot.countCols() - 1));

This comment has been minimized.

@wszymanski

wszymanski Nov 30, 2018

Member

You could use also every, but decission about using it is up to you.

@wszymanski wszymanski assigned jansiegel and unassigned wszymanski Nov 30, 2018

@wszymanski
Copy link
Member

wszymanski left a comment

<3

@jansiegel

This comment has been minimized.

Copy link
Member Author

jansiegel commented Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.