Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The afterValidate hook should provide the physical row index. #3132

Closed
jansiegel opened this issue Jan 18, 2016 · 1 comment
Closed

The afterValidate hook should provide the physical row index. #3132

jansiegel opened this issue Jan 18, 2016 · 1 comment
Assignees
Milestone

Comments

@jansiegel
Copy link
Member

@jansiegel jansiegel commented Jan 18, 2016

When validating a cell after the table has been sorted, the afterValidate hook should provide the physical row index (row index of the visually edited cell), not the row index from before sorting.

This will be a breaking change

@jansiegel jansiegel self-assigned this Jan 18, 2016
@jansiegel jansiegel added this to the 0.20.4 milestone Jan 18, 2016
jansiegel added a commit that referenced this issue Jan 18, 2016
…astAfterValidate hooks (instead of the 'base' row index) #3132
@jansiegel jansiegel assigned budnix and unassigned jansiegel Jan 18, 2016
@budnix budnix assigned jansiegel and unassigned budnix Jan 18, 2016
@jansiegel jansiegel changed the title The afterValidation should provide the physical row index. The afterValidate hook should provide the physical row index. Jan 20, 2016
@krzysztofspilka

This comment has been minimized.

Copy link
Member

@krzysztofspilka krzysztofspilka commented Jan 20, 2016

@budnix couldn't test it properly. Please make a peer review for me. Thx!

Jazzo added a commit to Jazzo/handsontable that referenced this issue Jan 23, 2016
* commit '461a1eefb66b3938589c76de0d10d9b93e6dba8a': (190 commits)
  0.21.0
  Update documentation
  Update documentation
  Fixed throwing error when no first argument was passed. handsontable#933
  Fix wrong variable declaration. handsontable#3014
  Fix invalid sorting on a horizontally scrolled table. handsontable#3014
  Remove the 'private' annotation from some helper classes to prevent 404s in the documentation.
  Add missing property types
  Add mising property type
  Add the HOT-Pro properties to the core in order to make them work in ngHandsontable.
  Fixed context menu tests
  Added missing tests and fixed submenu position when page has window scrollbars. handsontable#3124
  Rename physicalRow and physicalCol to visualRow and visualCol in the cell properties. handsontable#3132
  Pass the visual row index to the afterValidate, beforeValidate and poastAfterValidate hooks (instead of the 'base' row index) handsontable#3132
  Added delay for open submenu action. handsontable#3126
  Fix problems with pasting data near the bottom edge on the Pro version.
  Fixed submenu position when it doesn't fit to the browser's viewport. handsontable#3124
  Update autoRowSize and autoColumnSize docs.
  Another approach to handsontable#2816 + tests
  Prevent inserting 'null' inside empty rows when using the HTML renderer. handsontable#2816
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.