New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handsontable: Date Picker alignment issue in case of last row at bottom of page #3483
Comments
I think that this should be marked as a change. Currently you don't actually have a choice to allow the date picker to open above the cell. |
Thanks @AMBudnik, Currently select dropdown is working like that when we verified, only issue is with date picker. |
Hi @AMBudnik , it would be very helpful if any one help on this , my team also facing same issue, |
@Suresh437 our developers already know the case so in any spare time this issue should be fixed. |
Is there any progress on this or information about when it will be implemented? Or any workarounds found? |
Hi @thenoune |
After fiddling with it a little bit I discovered this: Replace line in handsontable.full.js below where it sets the position of the date picker in
with the following if statement that checks to see if the position of the cell is within 224px of the bottom of the window and if so, removes 224px from the top measurement.
|
related: #3957 |
Is there any outlook on a fix for this? This annoyance is one that would be great to solve. |
I truly understand that is is not elegant and can be annoying but we did not schedule the issue yet. |
For anybody who faces the same problem and found this issue, here is a little helper class that opens the datepicker to the top if needed: https://gist.github.com/alarie/e66376ea8e06070864e1ba751043d05a |
For now I updated the offsets of the Date picker Widget Open handsontable.full.ts and look for below Use the below code (change as per your need) to adjust Date Widget's co-ordinates: In my case the overlap was either for the last cells or because of right hand side overlapping of window border.
|
I found another solution. |
inform forum |
@AMBudnik any update on this issue? Because we are facing same issue. And while trying the to fix the same with some above mentioned solutions we got |
Sorry @lokesh-soni there are no updates on that issue yet |
The hack from @cdeepak76 makes this issue at least bearable in the short term. |
@lokesh-soni the error was caused by the offset is not defined in you version of handsontable. take a look at |
Can someone please explain how to properly use @alarie 's gist to make it work? I have tried it and even though I can confirm that the table's instance settings have the editor set up, when I debug the click event it runs the original showDatepicker function from handsontable.js Using the workaround provided by @cdeepak76 is not an option because we have a git project and handsontable is installed via npm package... so altering the source (handsontable.full.js) is not viable. |
@fmaiabatista I'm not 100% sure because i'm not using the DatePicker anymore in my project, but I think you have to overwrite the |
Demo for tests 11.1 https://jsfiddle.net/dL1ae9b7/1/ |
The datepicker does not change its position in 12.1.3 as well. Updated demo https://jsfiddle.net/g3q64p1a/ Here we'd expect the picker to flit and open upwards. |
How to change the date picker pop-up opening direction, so it opens upwards if there is not enough space below the edited cell(last row at bottom of page).Can any one help on this ASAP.
The text was updated successfully, but these errors were encountered: