Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing source value for some hooks triggered by plugins #4017

Closed
budnix opened this Issue Jan 25, 2017 · 3 comments

Comments

@budnix
Copy link
Member

budnix commented Jan 25, 2017

Description

There's a missing source value (last argument) for some hooks triggered by plugins. It can be helpful for developer who works with Handsontable to know about who triggered the action. Currently some hooks are better described as afterChange and some need more attention like afterCreateRow. Generally all hooks should be checked.

Steps to reproduce

  1. Go to http://jsfiddle.net/budnix/qb3tq9c6/;
  2. Try to perform any action that will triggers adding new rows (eq. via context menu, autofill);
  3. In DevTool you will see logged hooks with source as undefined.

Demo

http://jsfiddle.net/budnix/qb3tq9c6/

Your environment

  • Handsontable version: 0.30.0
  • Browser Name and version: any
  • Operating System: any
@budnix

This comment has been minimized.

Copy link
Member Author

budnix commented Jan 30, 2017

@budnix

This comment has been minimized.

Copy link
Member Author

budnix commented Feb 3, 2017

As it's a Breaking Change fix (as label states) here's a list of changed sources:

Renamed:

  • 'autofill' => 'Autofill.fill';
  • 'external' => 'ObserveChanges.change';
  • 'paste' => 'CopyPaste.paste';
  • 'undo' => 'UndoRedo.undo';
  • 'redo' => 'UndoRedo.redo';
  • 'ganttChart' => 'GanttChart.loadData';
  • 'columnSummary' => 'ColumnSummary.reset';
  • 'columnSummary' => 'ColumnSummary.set';

New:

  • 'ContextMenu.clearColumns';
  • 'ContextMenu.columnLeft';
  • 'ContextMenu.columnRight';
  • 'ContextMenu.removeColumn';
  • 'ContextMenu.removeRow';
  • 'ContextMenu.rowAbove';
  • 'ContextMenu.rowBelow';
  • 'ContextMenu.rowBelow';

Unchanged:

  • 'spliceCol';
  • 'spliceRow';
  • 'edit';
  • 'auto';
  • 'loadData';
  • 'populateFromArray';
  • 'dateValidator';
  • 'timeValidator';
  • 'validateCells';

@jansiegel jansiegel modified the milestones: 0.31.0, Backlog Feb 13, 2017

@swistach swistach added the Tested label Feb 13, 2017

@AMBudnik

This comment has been minimized.

Copy link
Contributor

AMBudnik commented Feb 14, 2017

Thanks for adding @budnix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.