Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tempElem.className.indexOf is not a function #4120

Closed
MarshallChen opened this issue Mar 9, 2017 · 6 comments

Comments

Projects
None yet
6 participants
@MarshallChen
Copy link

commented Mar 9, 2017

I'm using SVG element in table cell, so the problem is SVG element.className doesn't have indexOf function, error come from this line. Should I make a PR to fix this?

@AMBudnik

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2017

Hi @MarshallChen

If you have tested the example you can share a Pull request but please remember to compose it from the developer branch.

@MarshallChen

This comment has been minimized.

Copy link
Author

commented Mar 13, 2017

I think it should be as simple as change this line

if (tempElem.className.indexOf('wtHolder') > -1) 

to this

if (tempElem.getAttribute('class') && tempElem.getAttribute('class').indexOf('wtHolder') > -1)

It doesn't looks good but it should works, if the PR is needed let me know. PR here #4127

@AMBudnik

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2017

Hi @MarshallChen

Thank you for the pull request. Our devs will check it in the earliest convenience

@aaronbeall

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

@AMBudnik FYI this bug looks obsolete or fixed by other changes. I was looking into the same issue in another area of code, found this bug, saw @MarshallChen's PR never got merged but the current code has changed such that the original bug-code described here is gone. 🥂

@AMBudnik

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Thank you for the input :) I can see that @pnowak took his hands on it.

@AMBudnik

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Hey @MarshallChen please update to 7.1.0 We've just fixed it :)

@AMBudnik AMBudnik closed this Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.