Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes related to new naming policy inside Filters plugin #4358

Closed
wszymanski opened this Issue Jun 30, 2017 · 1 comment

Comments

Projects
None yet
4 participants
@wszymanski
Copy link
Member

commented Jun 30, 2017

Description

We will change the name of filter expressions by which column are filtered. As far filtering conditions have been called formulas. From now we will call them just conditions. It's related to clarifying naming convention (connected with the fact that already exists Formulas plugin).

API will change. For example from function addFormula to addCondition as shown in examples below.

From:

hot.getPlugin('filters').addFormula(1, 'begins_with', ['de']);

to:

hot.getPlugin('filters').addCondition(1, 'begins_with', ['de']);

From:

hot.getPlugin('filters').removeFormulas();

to:

hot.getPlugin('filters').removeConditions();

From:

hot.getPlugin('filters').clearFormulas();

to:

hot.getPlugin('filters').clearConditions();

Within this task will be done all needed changes to Community Edition of Handsontable.

@AMBudnik

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2017

Happy to see updated docs as well. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.