Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent in exporting Handsontable #4605

Closed
budnix opened this Issue Nov 10, 2017 · 0 comments

Comments

@budnix
Copy link
Member

budnix commented Nov 10, 2017

Description

While reviewing this PR I've noticed that Handsontable is exported in a different way. Handsontable uses default or named export in relation to the environment that has been build for.

Currently, for "browser" environment (dist/ files) Handsontable is exported as "named" and the for the rest (CommonJS, esNext) it is exported as default. This makes TypeScript definition incompatible with the second environment.

Your environment

  • Handsontable version: 0.34.5
  • Browser Name and version: -
  • Operating System: -
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.