Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.10.2+] Filter by value erased by checkboxes in cells #4780

Closed
AMBudnik opened this issue Feb 6, 2018 · 3 comments

Comments

@AMBudnik
Copy link
Contributor

@AMBudnik AMBudnik commented Feb 6, 2018

Description

The list of values is the filter_by_value is erased when we check any of the checkboxes in the table.

Steps to reproduce

  1. Open the dropdown menu for column A
  2. Uncheck Lorem
  3. Check any checkbox from column G
  4. Open dropdown menu

Result:
All options in the filter by value are unchecked.
gif

Expected:
All the options in the filter by value besides Lorem are checked.

Demo

http://jsfiddle.net/r6L3sy6b/

Your environment

  • Handsontable version: 1.15.1
  • Browser Name and version: Chrome 63
  • Operating System: Windows 10
@AMBudnik

This comment has been minimized.

Copy link
Contributor Author

@AMBudnik AMBudnik commented Apr 5, 2018

The issue started to appear from version 1.10.2. Working v1.10.1

It looks like the position or state of the checkbox doesn't have any impact on the issue. Here's a simplified example http://jsfiddle.net/handsoncode/52ajx2dp/. Always when you use filter_by_value and uncheck any of the options there, use checkbox inside the Handsontable and get back to the filter_by_value list all the checkboxes are unchecked.

We should definitely take a look at #5041 as it is very similar and it also broke down in v 1.10.2

@AMBudnik AMBudnik added the Regression label Apr 5, 2018
@AMBudnik AMBudnik changed the title Filter by value erased by checkboxes in cells [1.10.2+] Filter by value erased by checkboxes in cells Apr 5, 2018
@wojciechczerniak wojciechczerniak added this to the May 2018 milestone Apr 5, 2018
@AMBudnik

This comment has been minimized.

Copy link
Contributor Author

@AMBudnik AMBudnik commented Apr 27, 2018

Fixing this bug may also fix #4345 and/or #4311

@swistach swistach self-assigned this Apr 30, 2018
@swistach

This comment has been minimized.

Copy link
Contributor

@swistach swistach commented May 9, 2018

It will be fixed here: handsontable/handsontable-pro#72

@swistach swistach closed this May 9, 2018
@swistach swistach removed this from the May 2018 milestone May 9, 2018
@AMBudnik AMBudnik added this to the June 2018 milestone Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.