Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper rendering of selection borders on `develop` #4870

Closed
jansiegel opened this issue Feb 28, 2018 · 0 comments
Assignees
Milestone

Comments

@jansiegel
Copy link
Member

@jansiegel jansiegel commented Feb 28, 2018

Description

After merging the rewritten Merge Cells plugin to the current (pre-0.37.0) develop, some problems emerged:

Improper rendering of single-cell selection borders in one-column table:

  1. Go to http://jsfiddle.net/js_ziggle/sLm9quo0/
  2. Click any cell

Result: The cell is not selected properly, the selection appears at the top of the table

Improper rendering of entire-column/entire-row selection:

  1. Go to http://jsfiddle.net/js_ziggle/k9kb2ugj/2/
  2. Select cells from A1 to A10 or from A1 to J1

Result: Parts of the selection borders are missing

Other problems with rendering borders:

  1. Go to http://jsfiddle.net/js_ziggle/k9kb2ugj/2/
  2. Select the J10 cell and start dragging the selection to H1, then to A1

Result: There's a border left on the left side of the H column.

@jansiegel jansiegel added this to the Next release milestone Feb 28, 2018
@jansiegel jansiegel self-assigned this Feb 28, 2018
jansiegel added a commit that referenced this issue Feb 28, 2018
* Fix improper selection border rendering. #4870

* Change var to const in border.spec.js
@AMBudnik AMBudnik closed this Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.