Skip to content

/handsontable

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data is shifted to create a second row #4888

Closed
AMBudnik opened this issue Mar 2, 2018 · 3 comments
Assignees
@budnix
Labels
Auto column size Core: alignment/height/width Status: Released Type: Bug
Milestone
August 2018

Comments

@AMBudnik
Copy link
Contributor

@AMBudnik AMBudnik commented Mar 2, 2018 •
edited

Description

Data is shifted to create a second row

Related #3437

Steps to reproduce

  1. Bug visible after loading the table

image

Demo

https://jsfiddle.net/eLf40h5h/

Your environment
@AMBudnik AMBudnik changed the title Data is shifted to create a second row [0.16.0+] Data is shifted to create a second row Apr 5, 2018
@AMBudnik AMBudnik added the Regression label Apr 5, 2018
@wojciechczerniak wojciechczerniak added this to the May 2018 milestone Apr 5, 2018
@wojciechczerniak wojciechczerniak removed this from the May 2018 milestone May 14, 2018
@jansiegel

This comment has been minimized.

Sign in to view
Copy link
Member

@jansiegel jansiegel commented May 14, 2018 •
edited

It's probably caused by autoColumnSize being introduced in 0.16.0, so it should probably be considered as a bug in autoColumnSize than a regression.
(without the autoColumnSize enabled, this situation should not be present https://jsfiddle.net/nw2wqhjo/)
@wojciechczerniak wojciechczerniak changed the title [0.16.0+] Data is shifted to create a second row Data is shifted to create a second row May 14, 2018
budnix added a commit that referenced this issue Jul 13, 2018
@budnix
Add missing method call in AutoColumnSize plugin
Verified
This commit was signed with a verified signature.
budnix Krzysztof Budnik
GPG key ID: E83F4C7E48CA4EDF Learn about signing commits
Loading status checks…
a73b763 
Issue: #4888
@budnix budnix self-assigned this Jul 16, 2018
budnix added a commit that referenced this issue Jul 16, 2018
@budnix
Remove extra space from tests
Verified
This commit was signed with a verified signature.
budnix Krzysztof Budnik
GPG key ID: E83F4C7E48CA4EDF Learn about signing commits
Loading status checks…
f531be8 
Issue: #4888
@budnix budnix mentioned this issue Jul 16, 2018
Merged
2 of 6 tasks complete
@budnix budnix added this to the August 2018 milestone Jul 16, 2018
@budnix

This comment has been minimized.

Sign in to view
Copy link
Member

@budnix budnix commented Jul 16, 2018 •
edited

After this, PR gets merged this bug will be fixed by adjusting the AutoColumnSize plugin parameters. For example by increasing the sampling ratio:

autoColumnSize: {
  samplingRatio: 10,
}
@wojciechczerniak

This comment has been minimized.

Sign in to view
Copy link
Member

@wojciechczerniak wojciechczerniak commented Aug 9, 2018

Demo for samplingRatio in 5.0.1 RC: https://jsfiddle.net/eLf40h5h/22/ 👍
@AMBudnik AMBudnik closed this Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budnix budnix

Labels
Auto column size Core: alignment/height/width Status: Released Type: Bug
Projects
None yet
Milestone
  August 2018
4 participants
@AMBudnik @jansiegel @budnix @wojciechczerniak
You can’t perform that action at this time.