Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to add columnIndex to queryMethod call? #4944

Closed
jeremy-smith-maco opened this issue Mar 16, 2018 · 7 comments
Closed

Possible to add columnIndex to queryMethod call? #4944

jeremy-smith-maco opened this issue Mar 16, 2018 · 7 comments

Comments

@jeremy-smith-maco
Copy link
Contributor

@jeremy-smith-maco jeremy-smith-maco commented Mar 16, 2018

Description

We are implementing a custom queryMethod but we need to know which column it is currently searching on as we are adding the ability to search per column. All this requires is a couple lines changing in the code. This is where the queryMethod callback is called:

var testResult = cellQueryMethod(queryStr, cellData);

Can easily just pass in the columnIndex by changing this
var testResult = cellQueryMethod(queryStr, cellData);
to this
var testResult = cellQueryMethod(queryStr, cellData, colIndex);

If not we can just clone the library and do it ourselves but just wanted to pose the idea.

@jeremy-smith-maco jeremy-smith-maco changed the title Possible to add columnIndex or prop to queryMethod call? Possible to add columnIndex to queryMethod call? Mar 16, 2018
@AMBudnik

This comment has been minimized.

Copy link
Contributor

@AMBudnik AMBudnik commented Mar 20, 2018

Thank you for sharing the idea. It sounds like a good plan.

@jeremy-smith-maco

This comment has been minimized.

Copy link
Contributor Author

@jeremy-smith-maco jeremy-smith-maco commented Nov 22, 2018

We no longer need this as we are bypassing the whole search query method now but can still leave it up as a feature in-case anyone else may want it.

@AMBudnik

This comment has been minimized.

Copy link
Contributor

@AMBudnik AMBudnik commented Nov 23, 2018

Thank you for an update @jeremy-smith-maco

@AMBudnik

This comment has been minimized.

Copy link
Contributor

@AMBudnik AMBudnik commented Dec 7, 2018

As mentioned in the #5042 I am temporarily closing this issue

@AMBudnik AMBudnik closed this Dec 7, 2018
@wojciechczerniak wojciechczerniak mentioned this issue May 6, 2019
3 of 6 tasks complete
@wojciechczerniak

This comment has been minimized.

Copy link
Member

@wojciechczerniak wojciechczerniak commented May 13, 2019

We've got PR for this #5980

@aninde

This comment has been minimized.

Copy link

@aninde aninde commented Oct 10, 2019

@jeremy-smith-maco according to your wish, we introduced cellProperties in 7.1.2 7.2.0. The new version will be released next week.
cellProperties was added to the arguments of search's queryMethod so that it would be possible to tell what kind of data was being queried.

const testResult = cellQueryMethod(queryStr, cellData, cellProperties);

@AMBudnik

This comment has been minimized.

Copy link
Contributor

@AMBudnik AMBudnik commented Oct 15, 2019

I'm happy to announce that we just released Handsontable 7.2.0. Again thank you for your feedback and constant support Jeremy.

@AMBudnik AMBudnik closed this Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.