Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pasting Text in Numeric Columns throwing Error #5258

Closed
agokulravikumar opened this issue Jul 13, 2018 · 3 comments
Closed

Pasting Text in Numeric Columns throwing Error #5258

agokulravikumar opened this issue Jul 13, 2018 · 3 comments
Labels
bug Copy-paste Plugin Status: Released

Comments

@agokulravikumar
Copy link

Description

Text is pasted in a numeric type column and the text is skipped if pasted in small number of rows. But when more number of rows is pasted, it throws error.

Steps to reproduce

In the Columns, Give the following,
type: 'numeric',
allowInvalid: false

Demo

Recorded a small video to replicate the issue in the Demo Js Fiddle
https://wetransfer.com/downloads/563e3798cd46e336b2ef3cce4adb989420180713075018/82ffa7

Your environment

  • Handsontable version:
  • Browser Name and version:
  • Operating System:
@AMBudnik
Copy link
Contributor

AMBudnik commented Jul 13, 2018 •
edited

HI @agokulravikumar

Thank you for sharing. I have replicated the issue using Win 1/ Chrome 67 and MS Excel 2016.
I couldn't find a version of Handsontable that supports that correctly

jeremy-smith-maco added a commit to jeremy-smith-maco/handsontable that referenced this issue Aug 29, 2018
@jeremy-smith-maco
Fixes uncaught TypeError while selecting invalid cell handsontable#5119
6c7446c 
handsontable#5258 handsontable#5128

If the cell wasn't rendered then it would return back null and would try and remove the class of a null object which would throw an exception. Added a basic null check.
@jeremy-smith-maco jeremy-smith-maco mentioned this issue Aug 29, 2018
Merged
6 tasks
@wojciechczerniak wojciechczerniak mentioned this issue Sep 11, 2018
Closed
@wojciechczerniak
Copy link
Contributor

Probably a duplicate of #5119. Please track #5119 for updates.

jansiegel pushed a commit that referenced this issue Oct 8, 2018
@jeremy-smith-maco @jansiegel
Fixes uncaught TypeError while selecting invalid cell #5119 #5258 #5128…
b911bab 
… (#5381)

If the cell wasn't rendered then it would return back null and would try and remove the class of a null object which would throw an exception. Added a basic null check.
@AMBudnik
Copy link
Contributor

Hi @agokulravikumar

please update to 6.1.0 and let me know if everything works fine now.

We've fixed this issue within this one #5119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Copy-paste Plugin Status: Released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wojciechczerniak @AMBudnik @agokulravikumar