Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor top offset incorrect when using preventOverflow with set height #5453

Closed
jeremy-smith-maco opened this Issue Oct 4, 2018 · 1 comment

Comments

Projects
None yet
4 participants
@jeremy-smith-maco
Copy link
Contributor

jeremy-smith-maco commented Oct 4, 2018

Description

(Running on develop branch)
Having preventOverflow set to horizontal and having a set height on the table causes editor top offset to be incorrect when scrolling veritcally. Related to #5073.

Steps to reproduce

  1. preventOverflow set to horizontal and have a set height
  2. Scroll vertically
  3. Open editor

Demo

Your environment

  • Handsontable version: 6.0.1 (develop)
  • Browser Name and version: Chrome
  • Operating System: Windows 10

jeremy-smith-maco added a commit to jeremy-smith-maco/handsontable that referenced this issue Oct 4, 2018

@AMBudnik AMBudnik added the Type: Bug label Oct 5, 2018

@wojciechczerniak wojciechczerniak added this to the December 2018 milestone Nov 5, 2018

jeremy-smith-maco added a commit to jeremy-smith-maco/handsontable that referenced this issue Nov 15, 2018

jeremy-smith-maco added a commit to jeremy-smith-maco/handsontable that referenced this issue Nov 29, 2018

jeremy-smith-maco added a commit to jeremy-smith-maco/handsontable that referenced this issue Dec 19, 2018

jeremy-smith-maco added a commit to jeremy-smith-maco/handsontable that referenced this issue Dec 19, 2018

swistach added a commit that referenced this issue Dec 19, 2018

Calculates top offset correctly for preventOverflow horizontal with s…
…et height #5453 (#5454)

* Calculates top offset correctly for preventOverflow horizontal with set height #5453

* Issue #5453 Fixed issue with fixed inputs scrolling

* Issue #5453 Fixed failing walkontable tests

* Issue #5453 Instantiate last scrolled when overlays is constructed

* Issue #5453 Fix merge mistake
@AMBudnik

This comment has been minimized.

Copy link
Contributor

AMBudnik commented Mar 6, 2019

I'm happy to inform that we've fixed the issue in v 7.0.0. Thank you again for your feedback, Jeremy.

@AMBudnik AMBudnik closed this Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.