Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the HiddenRows-related hooks to pluginHooks.js #5522

Closed
jansiegel opened this Issue Oct 18, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@jansiegel
Copy link
Member

jansiegel commented Oct 18, 2018

Description

Related to handsontable/handsontable-pro#163.

The new hooks:

  • beforeHideRows
  • afterHideRows
  • beforeUnhideRows
  • afterUnhideRows
  • beforeHideColumns
  • afterHideColumns
  • beforeUnhideColumns
  • afterUnhideColumns

need to be added to pluginHooks.js.

@jansiegel jansiegel added the Hiding label Oct 18, 2018

@jansiegel jansiegel added this to the November 2018 milestone Oct 18, 2018

@jansiegel jansiegel self-assigned this Oct 18, 2018

jansiegel added a commit that referenced this issue Oct 18, 2018

jansiegel added a commit that referenced this issue Oct 24, 2018

jansiegel added a commit that referenced this issue Nov 9, 2018

jansiegel added a commit that referenced this issue Dec 11, 2018

Add the HiddenRows-related hooks to pluginHooks.js #5522 (#5523)
* Add the HiddenRows-related hooks to pluginHooks.js #5522

* Extend the docs for the hiddenRows/hiddenColumns hooks. #5522

* Update the descriptions for 'hiding' and 'unhiding' hooks. #5522
@subashdbc

This comment has been minimized.

Copy link

subashdbc commented Jan 23, 2019

Hi Guys,
Waiting for these new hooks to be released :)

@AMBudnik

This comment has been minimized.

Copy link
Contributor

AMBudnik commented Mar 6, 2019

Hey @subashdbc

it just happened. Please update to 7.0.0 to use the new hooks :)

@subashdbc

This comment has been minimized.

Copy link

subashdbc commented Mar 7, 2019

Hi @AMBudnik

I am not sure If I have taken it correctly with regard to this release.
My thought From Forum was when we collapse and uncollapse the column we will get the indexes of hidden columns
But it seems it doesn't get hooked when I collapse and uncollapse JS Fiddle
Is it wrong or Am I missing something here?
Thanks

@AMBudnik

This comment has been minimized.

Copy link
Contributor

AMBudnik commented Mar 7, 2019

Thank you for mentioning that. As I was instructed collapsing uses hiddenColumns plugin only partially so it is never calling the hooks. However, we should further discuss this subject.

ps. here's a connected topic #4873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.