Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.1.0+] Cannot add comments to cells from context menu #5614

Closed
epsil opened this Issue Nov 26, 2018 · 5 comments

Comments

Projects
None yet
5 participants
@epsil
Copy link

epsil commented Nov 26, 2018

Description

It is not possible to add comments to cells by choosing Add comment from the context menu. The comment field disappears before one is able to type anything.

Steps to reproduce

  1. Open the demo below to get a large table with comments and context menu enabled.
  2. Right-click on the upper-left 2017 cell and select Add comment from the context menu.
  3. The comment field appears briefly. However, as soon as one moves the cursor towards it, it disappears.

It seems that the comment field disappears the moment one moves the cursor over a cell. If one right-clicks on the rightmost column, so that the context menu is outside the table, then one can reach the comment field without hovering over any cells.

Specifically, the bug is triggered only if the cursor is above a cell after interacting with the context menu. The comment field disappears when moving the cursor from that cell to another cell.

In other words, this bug doesn't affect "small" tables (i.e., smaller than the context menu). The demo initializes the table with a long data array to ensure that the resulting table is large enough.

Demo

http://jsfiddle.net/uhx6bL42/

Environment

  • Handsontable version: 6.2.0
  • Browser Name and version: Firefox Quantum 63.0.3 (also tested with Google Chrome 70.0.3538.102)
  • Operating System: Microsoft Windows 10 Enterprise
@AMBudnik

This comment has been minimized.

Copy link
Contributor

AMBudnik commented Nov 26, 2018

Thank you for sharing. I have replicated the issue.
It looks like 6.1.0 is responsible for this bug. In 6.0.1 it worked fine.

@AMBudnik AMBudnik changed the title Cannot add comments to cells from context menu [6.1.0+] Cannot add comments to cells from context menu Nov 26, 2018

@zekrix

This comment has been minimized.

Copy link

zekrix commented Jan 14, 2019

Any news here?
I updated Handsontable to latest and encountered same issue. Downgraded to earlier version, but has anyone come up with a proper fix?

@AMBudnik

This comment has been minimized.

Copy link
Contributor

AMBudnik commented Jan 14, 2019

I hope that we will be able to focus on this in February. The Regression bugs should be fixed in the first place but know we have something super-important that we need to finish (2-3 more weeks).

inform forum

@wojciechczerniak wojciechczerniak added this to the January 2019 milestone Jan 17, 2019

@AMBudnik

This comment has been minimized.

Copy link
Contributor

AMBudnik commented Jan 22, 2019

The issue should be solved with #5631

@AMBudnik

This comment has been minimized.

Copy link
Contributor

AMBudnik commented Mar 6, 2019

Hey @epsil @zekrix

we've just got it fixed in v 7.0.0. Thank you for your feedback.

@AMBudnik AMBudnik closed this Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.