Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handsontable should work properly in the container with relative dimensions (%, vh, vw, rem, em) #5749

Closed
swistach opened this Issue Jan 30, 2019 · 0 comments

Comments

@swistach
Copy link
Member

swistach commented Jan 30, 2019

Description

Currently, if you try to initialise Handsontable in the container with relative width and height, then the table's overlays have improper dimensions. Additionally, the vertical scroll will not work.

Moreover, our options, width and height, should allow using string values directly in configuration - eg.: 10vh, 40%, 40rem or even 100px as well.

Steps to reproduce

  1. Open a demo.

Demo

https://jsfiddle.net/g0cm63th/

Your environment

  • Handsontable version: any
  • Browser Name and version: any
  • Operating System: any

@swistach swistach added this to the January 2019 milestone Jan 30, 2019

@swistach swistach self-assigned this Jan 30, 2019

@swistach swistach changed the title Handsontable should work properly in the container with relative sizes (%, vh, vw, rem, em) Handsontable should work properly in the container with relative dimensions (%, vh, vw, rem, em) Jan 30, 2019

swistach added a commit that referenced this issue Jan 31, 2019

Added: support for string values in with and height properties, suppo…
…rt for relative dimensions of container/trimmingElement in theirs styles. Changed: contextMenu initialization in its enablePlugin() method - it's actually bugfix for MemoryLeak of mousedown listener in contextMenu/menu.js. #5749

swistach added a commit that referenced this issue Feb 4, 2019

swistach added a commit that referenced this issue Feb 4, 2019

swistach added a commit that referenced this issue Feb 4, 2019

swistach added a commit that referenced this issue Feb 5, 2019

Support for relative dimensions (%, vw, vh, em, rem...) (#5758)
* Added: support for string values in with and height properties, support for relative dimensions of container/trimmingElement in theirs styles. Changed: contextMenu initialization in its enablePlugin() method - it's actually bugfix for MemoryLeak of mousedown listener in contextMenu/menu.js. #5749

* Added: test + description in the defaultSettings file. #5749

* Revert ContextMenu to develop. #5749

* Added: missing typescript definition. #5749

@AMBudnik AMBudnik closed this Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.