Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The trimRows plugin don't update trimmed row indexes after rows insertion #5761

Closed
wszymanski opened this Issue Feb 5, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@wszymanski
Copy link
Member

wszymanski commented Feb 5, 2019

Description

As the title says.

Steps to reproduce

  1. Open the example: https://jsfiddle.net/adv1t8Lb/1/
  2. Open the web console.
  3. console.log(hot.getPlugin('trimRows').isTrimmed(1)); should log false (trimmed index should be updated).

Related issue(s):

  1. #5738

@wszymanski wszymanski added this to the February 2019 milestone Feb 5, 2019

@wszymanski wszymanski self-assigned this Feb 5, 2019

wszymanski added a commit that referenced this issue Feb 5, 2019

wszymanski added a commit that referenced this issue Feb 7, 2019

The trimRows plugin will update trimmed row indexes after rows insert…
…ion (#5768)

### Context
As the title says.
### How has this been tested?
Manual tests of the plugin, also with enabled `bindWithHeaders` plugin. Known problem: #5208 (comment).

### Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature or improvement (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Additional language file or change to the existing one (translations)
### Related issue(s):
1. #5761
### Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] My code follows the code style of this project,
- [ ] My change requires a change to the documentation.

@AMBudnik AMBudnik closed this Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.