Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a similar option to `skipColumnOnPaste` for autoFill #5845

Closed
AMBudnik opened this issue Mar 7, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@AMBudnik
Copy link
Contributor

commented Mar 7, 2019

Description

The option is useful when we use autoFill on hidden rows.

Your environment

  • Handsontable version: 7.0.0
  • Browser Name and version: Chrome 72
  • Operating System: Windows 10
@wojciechczerniak

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

I think that the option is already here and is called skipRowOnPaste:

if ((source === 'CopyPaste.paste' || source === 'Autofill.autofill') && cellMeta.skipRowOnPaste) {

But there is a small difference to skipColumnOnPaste:

if ((source === 'CopyPaste.paste' || source === 'Autofill.fill') && cellMeta.skipColumnOnPaste) {

One has condition source === 'Autofill.fill' while the other source === 'Autofill.autofill'.

The source that autofill calls populateFromArray is Autofill.fill:

`${this.pluginName}.fill`,

That's why it works for columns but not rows.

@wojciechczerniak wojciechczerniak added this to the April 2019 milestone Apr 4, 2019

pnowak added a commit that referenced this issue Apr 5, 2019

pnowak added a commit that referenced this issue Apr 12, 2019

jansiegel added a commit that referenced this issue May 6, 2019

jansiegel added a commit that referenced this issue May 6, 2019

jansiegel added a commit that referenced this issue May 6, 2019

Fix typo on `skipRowOnPaste ` and fix bug on autofill (#5957)
* correct a typo #5845

* getSelectedData in autofill omitting data from hidden cells #5845

* Add the docs for the `skipRowOnPaste` option. #5845

* Correct docs indentation. #5845
@AMBudnik

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

Thanks!

@AMBudnik AMBudnik closed this May 13, 2019

@AMBudnik AMBudnik modified the milestones: April 2019, March 2019 May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.