Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The selection cannot be moved with the keyboard when the last row/column is hidden #5877

Closed
AMBudnik opened this issue Feb 15, 2019 · 6 comments

Comments

@AMBudnik
Copy link
Contributor

Description

Steps to reproduce:

  1. Go to the demo
  2. Select A1
  3. Press → or ↓ four times

After the last visible cell in row, selection should be moved to the first visible cell in next row.
Problems occurs only when the last col/row is hidden.

Demo

http://jsfiddle.net/AMBudnik/d9pefh1m/

Your environment

  • Handsontable version: 6.2.2
  • Browser Name and version: Chrome 71
  • Operating System: Windows 10

Moved from GL #122

@AMBudnik AMBudnik transferred this issue from handsontable/handsontable-pro Mar 12, 2019
@AMBudnik
Copy link
Contributor Author

Also reproducible in v 7.0.0 http://jsfiddle.net/j9muzqtc/

@AMBudnik
Copy link
Contributor Author

It still does not move the selection in 8.0.0-beta1 http://jsfiddle.net/rvwdc8se/

@AMBudnik
Copy link
Contributor Author

AMBudnik commented May 8, 2020

Still broken in 8.0.0.-beta2-rev2 http://jsfiddle.net/9ea30bux/

HiddenColumns only work well http://jsfiddle.net/9ea30bux/1/ - this has been fixed in 8.0.0.-beta2-rev2 here #5704

@AMBudnik AMBudnik changed the title hiddenRows/hiddenColumns doesn't work properly with autoWrapRow/autoWrapCol hiddenRows doesn't work properly with autoWrapRow/autoWrapCol May 8, 2020
@AMBudnik
Copy link
Contributor Author

Solved in 8.0.0-beta2-rev13 http://jsfiddle.net/AMBudnik/fgz8dxLw/

@aninde
Copy link
Contributor

aninde commented Aug 6, 2020

Updated demo with v8.0.0 http://jsfiddle.net/aninde/gk5wu6oe/. Still working well. Issue closed as solved.

@aninde aninde closed this as completed Aug 6, 2020
@aninde aninde changed the title hiddenRows doesn't work properly with autoWrapRow/autoWrapCol T selection cannot be moved with the keyboard when the last row/column is hidden Oct 26, 2020
@aninde
Copy link
Contributor

aninde commented Oct 26, 2020

This bug can be reproduced without set autoWrapRow.autoWrap col, so I'm changing the title.
Updated demo - v6.2.2 http://jsfiddle.net/AMBudnik/d9pefh1m/.

@aninde aninde changed the title T selection cannot be moved with the keyboard when the last row/column is hidden The selection cannot be moved with the keyboard when the last row/column is hidden Oct 26, 2020
aninde added a commit that referenced this issue Oct 26, 2020
mrpiotr-dev pushed a commit that referenced this issue Oct 29, 2020
* #7171 - Adds missing test for #4303

* #7171 - Removes unnecessary E2E test file for hiddenColumns

* #7171 - Adds missing test case for #5207

* #7171 - Adds missing test cases for #3978

* #7171 - Fixes lint errors

* #7171 - Adds missing test cases for #7043

* #7171 - Adds missing test cases for #5000

* #7171 - Adds missing test cases for #5906

* Adds missing tests for #4897

* Changed test for #4897 so thay they only pass in version 8+

* Fixes tests for #4897

* #7171 - Adjustment missing test cases for #4897

* #7171 - Adds missing tests for #6670 and a missing legend for header selection symbols

* #7171 - Adjustment test cases of ##4897 for eslint

* #7171 - Adds missing tests for #7099

* #7171 - Fix linter errors in tests for #7099

* #7171 - Adds missing tests to #7095

* #7171 - Adds missing test cases for #7097

* #7171 - Adds missing expect to tests for #7095

* #7171 - Adds missing test for #6843

* #7171 - Adds missing tests for #7076

* #7171 - Adds missing tests for #6435

* #7171 - Adds missing tests for #3726

* #7171 - Adds missing test cases for #5849

* #7171 - Adds missing tests for #4154

* #7171 - Adjustment on test cases for #5849

* #7171 - Adds missing tests for #6433

* #7171 - Adds missing test cases for #6355

* Fix typo in comment

* #7171 - Adds missing tests for #6386

* #7171 - Adds missing tests for #6831

* #7171 - Adds missing tests for #6363

* #7171 - Adds missing tests for #4999

* #7171 - Adds missing tests for #6426

* #7171 - Adds missing tests for #6113

* #7171 - Adds missing tests for #6412

* #7171 - Adds missing tests for #6310

* #7171 - Adds missing test cases for #5877

* #7171 - Adds missing test for #5824

* #7171 - Adds missing tests for #4713

* #7171 - Adds missing tests for #4576

* #7171 - Changes spec description for #4576

* #7171 - Adds missing test cases for #4601

* #7171 - Adjustment on test cases for #4601

* #7171 - Reverts added tests for #5824 due to a bug #7355

* #7171 - Adds comment with @todo after removing ObserveChanges

Co-authored-by: ndemytruk <ndemytruk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants