Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm task for unit tests throws errors on Windows. #5878

Closed
AMBudnik opened this issue Feb 18, 2019 · 2 comments

Comments

@AMBudnik
Copy link
Contributor

commented Feb 18, 2019

Description

Handsontable tests are not working on Window' machines. There are some issues related to eslint rules. Also, the unit test task fails - there is a problem with getting environment variable on Windows.

Moved from GL #169

@AMBudnik AMBudnik transferred this issue from handsontable/handsontable-pro Mar 12, 2019

@AMBudnik

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

Please check if they are still an issue in this repository.

@swistach

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

Bug still exists.

https://github.com/handsontable/handsontable/blob/master/package.json#L28
Definition and use of the env variable in our tasks chain don't work on Windows.

npm run test:e2e called separately, works ok.

@swistach swistach changed the title Tests not working on Windows npm task for unit tests throws errors on Windows. Mar 12, 2019

@warpech warpech referenced this issue Jul 18, 2019
3 of 6 tasks complete

@wojciechczerniak wojciechczerniak added this to the July 2019 milestone Jul 18, 2019

@jansiegel jansiegel assigned warpech and unassigned jansiegel Jul 19, 2019

warpech added a commit that referenced this issue Jul 22, 2019

@AMBudnik AMBudnik closed this Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.