Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getCell topmost doesn’t work for fixedRowsBottom = 1 #5896

Closed
m2a2x opened this issue Mar 17, 2019 · 3 comments

Comments

Projects
None yet
4 participants
@m2a2x
Copy link

commented Mar 17, 2019

getCell(row, column, topmost)
topmost - If set to true, it returns the TD element from the topmost overlay. For example,
if the wanted cell is in the range of fixed rows, it will return a TD element from the top overlay.

But it doesn't work if:
fixedRowsBottom = 1

It returns bottom td, not top one.
Could be checked here:
https://jsfiddle.net/h4d1La3m/

Your environment

  • Handsontable version: 6.2+
  • Browser Name and version: chrome
  • Operating System: mac/windows
@wojciechczerniak

This comment has been minimized.

Copy link
Member

commented Mar 17, 2019

Only when we want to get first fixed bottom row. Works for the second one: https://jsfiddle.net/rL23mh1j/

We're missing >= in this line?

} else if (coords.row < totalRows && coords.row > totalRows - fixedRowsBottom) {

@AMBudnik

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

inform forum

@wojciechczerniak wojciechczerniak modified the milestones: April 2019, May 2019 Apr 16, 2019

pnowak added a commit that referenced this issue May 21, 2019

@pnowak pnowak referenced this issue May 21, 2019

Merged

improving the check in getCell #6023

2 of 6 tasks complete

pnowak added a commit that referenced this issue May 31, 2019

pnowak added a commit that referenced this issue May 31, 2019

improving the check in getCell (#6023)
* improving the check in getCell #5896
@AMBudnik

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Released in v 7.1.0 :) Please update and share your feedback.

@AMBudnik AMBudnik closed this Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.