Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing rootInstanceSymbol in Handsontable.Core #6040

Closed
swistach opened this issue Jun 5, 2019 · 0 comments

Comments

@swistach
Copy link
Member

commented Jun 5, 2019

Description

To initialize Handsontable correctly by using new Handsontable.Core, we need to add rootInstanceSymbol into it. Without the third argument, the created instance has not a valid symbol https://github.com/handsontable/handsontable/blob/master/src/core.js#L88

Steps to reproduce

  1. Go to the demo: https://stackblitz.com/edit/js-q7ldvr

Demo

https://stackblitz.com/edit/js-q7ldvr

Your environment

  • Handsontable version: (pro) 2.0.0+
  • Browser Name and version: any
  • Operating System: any

@swistach swistach added this to the June 2019 milestone Jun 5, 2019

@swistach swistach self-assigned this Jun 5, 2019

swistach added a commit that referenced this issue Jun 5, 2019

swistach added a commit that referenced this issue Jun 5, 2019

swistach added a commit that referenced this issue Jun 6, 2019

swistach added a commit that referenced this issue Jun 13, 2019

Added missing rootInstanceSymbol to Handsontable.Core (#6041)
* Added: missing rootInstanceSymbol to Handsontable.Core + test specs for settings.licenseKey. #6040

* Added untracked files. #6040

* Changed: use function instead of arrow-function. #6040

@AMBudnik AMBudnik closed this Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.