Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultSettings for comments is wrong #6125

Closed
pnowak opened this issue Jul 17, 2019 · 0 comments

Comments

@pnowak
Copy link
Member

commented Jul 17, 2019

Description

defaultSettings says that you can pass comment objects:

// or
// enable comments plugin and add predefined comments
comments: [
  {
    row: 1,
    col: 1,
    comment: {
      value: "Test comment"
    }
  }
],

But this is wrong.
Also, the comments config has a property displayDelay.

Steps to reproduce

  1. handsontable/docs#32

@pnowak pnowak self-assigned this Jul 17, 2019

pnowak added a commit that referenced this issue Jul 17, 2019

@pnowak pnowak added this to the July 2019 milestone Jul 17, 2019

@pnowak pnowak referenced this issue Jul 17, 2019
2 of 6 tasks complete

pnowak added a commit that referenced this issue Jul 18, 2019

pnowak added a commit that referenced this issue Jul 18, 2019

Fixed an example for comments in deafultSettings (#6126)
* Fixed an example for comments in deafultSettings #6125

@AMBudnik AMBudnik closed this Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.