Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable ContextMenu's container #6283

Closed
swistach opened this issue Sep 23, 2019 · 1 comment
Closed

Configurable ContextMenu's container #6283

swistach opened this issue Sep 23, 2019 · 1 comment

Comments

@swistach
Copy link
Contributor

@swistach swistach commented Sep 23, 2019

Description

Due to we still need to rethink how configurable container for editors should work, we decided to move part of #6202 scope about ContextMenu to the separated issue.

To-do list:

  • New option in the settings object - where the plugin should insert elements
  • If the container's not set we should have a default element (for backward compatibility)

Additionally we can fix:

  • #3446 - ContextMenu should not open another instance if a user clicked RMB on the command item
  • #5846 - native context menu should not call mousemove's callback in the dragToScroll plugin
  • #6218 - ContextMenu should not allow to open native context menu on itself
@swistach swistach added this to the September 2019 milestone Sep 23, 2019
@swistach swistach self-assigned this Sep 23, 2019
@swistach swistach changed the title Configurable ConextMenu's container Configurable ContextMenu's container Sep 23, 2019
swistach added a commit that referenced this issue Sep 26, 2019
swistach added a commit that referenced this issue Sep 30, 2019
…ragToScroll, #6283
@swistach swistach mentioned this issue Oct 1, 2019
1 of 1 task complete
swistach added a commit that referenced this issue Oct 3, 2019
…rted changes for mixed frames event propagation onkeydown. #6283
swistach added a commit that referenced this issue Oct 4, 2019
…mouse button on ContextMenu's item. #6283
swistach added a commit that referenced this issue Oct 7, 2019
…hook instead of . First part of test specs adjustments. #6283
swistach added a commit that referenced this issue Oct 8, 2019
… events. #6283
swistach added a commit that referenced this issue Oct 8, 2019
…UI container. #6283
swistach added a commit that referenced this issue Oct 9, 2019
swistach added a commit that referenced this issue Oct 9, 2019
swistach added a commit that referenced this issue Oct 16, 2019
…stead document.documentElement. #6283
swistach added a commit that referenced this issue Oct 22, 2019
…too. [skip ci] #6283
swistach added a commit that referenced this issue Oct 23, 2019
…s correct if documents are different. #6283
swistach added a commit that referenced this issue Oct 31, 2019
* Changed: contextMenu uses configurable container. #6283

* Changed: contextMenu's positioning to support iframe. Adjustment in dragToScroll, #6283

* Changed: event propagation for right click on contextMenu items. Reverted changes for mixed frames event propagation onkeydown. #6283

* Changed: prevented opening native context menu by clicking the right mouse button on ContextMenu's item. #6283

* Changed: contextMenu/dropdownMenu/FilterUISelect executes command on  hook instead of . First part of test specs adjustments. #6283

* Adjusted: contextMenu's items will be executed on mouseup/contextmenu events. #6283

* Changed: property name of UI container. Added: test specs for custom UI container. #6283

* Changed: dropdownMenu requires colHeaders to work. #6283

* Added: tests for added functionalities. #6283

* Changed: default container for ContextMenu should be document.body instead document.documentElement. #6283

* Changed: position's calculations have to base on event.view's scroll too. [skip ci] #6283

* Added: test scenario to verify contextmenu UI elements' positioning is correct if documents are different. #6283
jansiegel added a commit that referenced this issue Nov 4, 2019
* Changed: contextMenu uses configurable container. #6283

* Changed: contextMenu's positioning to support iframe. Adjustment in dragToScroll, #6283

* Changed: event propagation for right click on contextMenu items. Reverted changes for mixed frames event propagation onkeydown. #6283

* Changed: prevented opening native context menu by clicking the right mouse button on ContextMenu's item. #6283

* Changed: contextMenu/dropdownMenu/FilterUISelect executes command on  hook instead of . First part of test specs adjustments. #6283

* Adjusted: contextMenu's items will be executed on mouseup/contextmenu events. #6283

* Changed: property name of UI container. Added: test specs for custom UI container. #6283

* Changed: dropdownMenu requires colHeaders to work. #6283

* Added: tests for added functionalities. #6283

* Changed: default container for ContextMenu should be document.body instead document.documentElement. #6283

* Changed: position's calculations have to base on event.view's scroll too. [skip ci] #6283

* Added: test scenario to verify contextmenu UI elements' positioning is correct if documents are different. #6283
@swistach swistach added the Epic label Nov 18, 2019
@aninde

This comment has been minimized.

Copy link

@aninde aninde commented Nov 27, 2019

Demo for testing https://jsfiddle.net/ka5ub68q/. Works as intended. contextMenu and dropdown Menu are visible and are not cropped by iframe, when they have uiContainer: document.getElementById('childlessParent').

@AMBudnik AMBudnik closed this Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.