Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IE11] helper.htmlToGridSettings throws error when used with iframe child table #6350

Closed
jacekbogdanski opened this issue Oct 17, 2019 · 5 comments

Comments

@jacekbogdanski
Copy link

@jacekbogdanski jacekbogdanski commented Oct 17, 2019

Description

The issue exists on IE11 (didn't test on lower IE versions) when the target table is a part of an iframe. Using Handsontable.helper.htmlToGridSettings throws an error when at some point HTMLCollection is checked against array type.

Note that everything works fine if a table is not a part of an iframe.

Steps to reproduce

  1. Create iframe element with nested sample table.
  2. Execute Handsontable.helper.htmlToGridSettings on the table queried from iframe element.

Expected

The table should be successfully converted into settings object.

Actual

image

Demo

https://jsbin.com/hequkic/edit?html,js,console,output

Your environment

  • Handsontable version: 7.1.1
  • Browser Name and version: latest IE11
  • Operating System: Windows 10
@AMBudnik AMBudnik added the Type: Bug label Oct 17, 2019
@AMBudnik

This comment has been minimized.

Copy link
Contributor

@AMBudnik AMBudnik commented Oct 17, 2019

Thanks, Jacek. Already on it. We'll stay in touch.

@AMBudnik AMBudnik removed the Type: Bug label Oct 17, 2019
@swistach swistach self-assigned this Oct 17, 2019
swistach added a commit that referenced this issue Oct 17, 2019
@swistach swistach added this to the October 2019 milestone Oct 17, 2019
swistach added a commit that referenced this issue Oct 18, 2019
)
@aninde

This comment has been minimized.

Copy link

@aninde aninde commented Oct 22, 2019

@jacekbogdanski this issue will be fixed by 7.2.2. We plan to release it tomorrow.
In 7.2.2 v. there isn't error in console.

I'm working on MacOS, so I tested it on Browserstack/Win 10/ IE 11.
I asked our support for help with testing directly on Windows 10 and IE 11 and results are the same.

This bug is only replicable on IE.

Demo:
v. 7.2.2 fixed https://jsbin.com/zuvawex/3/edit?html,js,console,output
Browser Name and version: Windows 10
Operating System: IE 11

@AMBudnik

This comment has been minimized.

Copy link
Contributor

@AMBudnik AMBudnik commented Oct 22, 2019

Windows user confirming - works well now :)

@jacekbogdanski

This comment has been minimized.

Copy link
Author

@jacekbogdanski jacekbogdanski commented Oct 22, 2019

That was quick, thank you :)

@AMBudnik

This comment has been minimized.

Copy link
Contributor

@AMBudnik AMBudnik commented Oct 23, 2019

Hey @jacekbogdanski already published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.