Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minSpareCols with undo adds too many columns #6363

Closed
AMBudnik opened this issue Oct 21, 2019 · 6 comments
Closed

minSpareCols with undo adds too many columns #6363

AMBudnik opened this issue Oct 21, 2019 · 6 comments

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented Oct 21, 2019

If we add minSpareCols to the equation it is easier to get the columns back but we get too many columns.

Updated demo https://jsfiddle.net/handsoncode/5cwb9agr/

Steps to reproduce

  1. Select A and B column by dragging
  2. Use the context menu to delete columns
  3. Undo

Result
We get 4 columns instead of 3. With 2 spare columns, there are 6 columns after undo and so on.

66485094-7a5f9300-eaa8-11e9-92e4-8d52f57d0c87

Your environment

  • Handsontable version: 7.2.1
  • Browser Name and version: Chrome 77
  • Operating System: Windows 10

Moved from https://github.com/handsontable/dev-handsontable/issues/106

@AMBudnik

This comment has been minimized.

@AMBudnik

This comment has been minimized.

@AMBudnik
Copy link
Contributor Author

Using pre 8.0.0-beta2 on Windows 10 / Chrome 83

Main case - solved

Demo https://jsfiddle.net/Lswxrvdq/
Result
ok

Case 2 - still replicable

Demo https://jsfiddle.net/fydxcvhL/

Case 3 - still replicable

Demo https://jsfiddle.net/cLt9wk80/

@AMBudnik
Copy link
Contributor Author

I moved cases 2 and 3 to a separate issue https://github.com/handsontable/dev-handsontable/issues/381

@wojciechczerniak wojciechczerniak mentioned this issue Jul 13, 2020
204 tasks
@aninde
Copy link
Contributor

aninde commented Jul 22, 2020

Main case is still fixed with pre-8.0.0-rev1 https://jsfiddle.net/aninde/f9op4c7z/.

@AMBudnik
Copy link
Contributor Author

AMBudnik commented Aug 6, 2020

Updated demo v 8.0.0 https://jsfiddle.net/5qsyr6ae/ Issue solved (along with the missing border visible on the demo above)

@AMBudnik AMBudnik closed this as completed Aug 6, 2020
mrpiotr-dev added a commit that referenced this issue Oct 26, 2020
mrpiotr-dev pushed a commit that referenced this issue Oct 29, 2020
* #7171 - Adds missing test for #4303

* #7171 - Removes unnecessary E2E test file for hiddenColumns

* #7171 - Adds missing test case for #5207

* #7171 - Adds missing test cases for #3978

* #7171 - Fixes lint errors

* #7171 - Adds missing test cases for #7043

* #7171 - Adds missing test cases for #5000

* #7171 - Adds missing test cases for #5906

* Adds missing tests for #4897

* Changed test for #4897 so thay they only pass in version 8+

* Fixes tests for #4897

* #7171 - Adjustment missing test cases for #4897

* #7171 - Adds missing tests for #6670 and a missing legend for header selection symbols

* #7171 - Adjustment test cases of ##4897 for eslint

* #7171 - Adds missing tests for #7099

* #7171 - Fix linter errors in tests for #7099

* #7171 - Adds missing tests to #7095

* #7171 - Adds missing test cases for #7097

* #7171 - Adds missing expect to tests for #7095

* #7171 - Adds missing test for #6843

* #7171 - Adds missing tests for #7076

* #7171 - Adds missing tests for #6435

* #7171 - Adds missing tests for #3726

* #7171 - Adds missing test cases for #5849

* #7171 - Adds missing tests for #4154

* #7171 - Adjustment on test cases for #5849

* #7171 - Adds missing tests for #6433

* #7171 - Adds missing test cases for #6355

* Fix typo in comment

* #7171 - Adds missing tests for #6386

* #7171 - Adds missing tests for #6831

* #7171 - Adds missing tests for #6363

* #7171 - Adds missing tests for #4999

* #7171 - Adds missing tests for #6426

* #7171 - Adds missing tests for #6113

* #7171 - Adds missing tests for #6412

* #7171 - Adds missing tests for #6310

* #7171 - Adds missing test cases for #5877

* #7171 - Adds missing test for #5824

* #7171 - Adds missing tests for #4713

* #7171 - Adds missing tests for #4576

* #7171 - Changes spec description for #4576

* #7171 - Adds missing test cases for #4601

* #7171 - Adjustment on test cases for #4601

* #7171 - Reverts added tests for #5824 due to a bug #7355

* #7171 - Adds comment with @todo after removing ObserveChanges

Co-authored-by: ndemytruk <ndemytruk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants