Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.0] After Updating mobile editing does not work #6707

Closed
mariomacedo opened this issue Feb 12, 2020 · 3 comments
Closed

[7.4.0] After Updating mobile editing does not work #6707

mariomacedo opened this issue Feb 12, 2020 · 3 comments
Assignees
@budnix
Labels
Mobile Regression Status: Released Type: Bug

Comments

@mariomacedo
Copy link

@mariomacedo mariomacedo commented Feb 12, 2020

Description

After updating for this new minor release (7.4.0) I can't edit value in a cell on mobile devices.

Demo

http://jsfiddle.net/handsoncode/s6t768pq

Your environment

  • Handsontable version: 7.4.0
  • Browser Name and version: Chrome 80.0.3987.87
  • Operating System: Android 9 / iOS 13
@budnix budnix self-assigned this Feb 13, 2020
@budnix budnix added Regression Type: Bug Status: In development labels Feb 13, 2020
@aninde
Copy link
Contributor

@aninde aninde commented Feb 13, 2020

The same demo doesn't work on iPad via BrowserStack.

budnix added a commit that referenced this issue Feb 13, 2020
@budnix
Fix dbl click events on mobile devices (touch events)
49daa9b 
On PCs, we run internal hooks about dbl click only when they are
triggered only by LMB. When mobile devices are used or any device which
supports touch events, that expression blocks the logic, which is
necessary for opening editors, for example. When origin event comes from
touch event, button ID checking is ignored, and dbl click hook is
fired.

Issue: #6707
@budnix budnix mentioned this issue Feb 13, 2020
Merged
6 tasks
budnix added a commit that referenced this issue Feb 13, 2020
@budnix
Fix dbl click events on mobile devices (touch events) (#6709)
cf66157 
On PCs, we run internal hooks about dbl click only when they are
triggered only by LMB. When mobile devices are used or any device which
supports touch events, that expression blocks the logic, which is
necessary for opening editors, for example. When origin event comes from
touch event, button ID checking is ignored, and dbl click hook is
fired.

Issue: #6707
jansiegel pushed a commit that referenced this issue Feb 18, 2020
@budnix @jansiegel
Fix dbl click events on mobile devices (touch events) (#6709)
17b8c33 
On PCs, we run internal hooks about dbl click only when they are
triggered only by LMB. When mobile devices are used or any device which
supports touch events, that expression blocks the logic, which is
necessary for opening editors, for example. When origin event comes from
touch event, button ID checking is ignored, and dbl click hook is
fired.

Issue: #6707
@aninde aninde mentioned this issue Feb 18, 2020
Closed
34 tasks
@aninde
Copy link
Contributor

@aninde aninde commented Feb 18, 2020

@mariomacedo this bug will be fixed by 7.4.1 v.. We plan to release it soon.

Tested on:
iPhone S / iOS 13.3.1 / Safari (live)
iPad / iOS 13.3.1 (live)
Huawei Mate 20 / Android 10 / Chrome / Chrome Canary / Edge / Firefox (live)
Mi A2 Lite / Android 8.1.0 / Chrome (live)
Galaxy J4+ / Android 8.1.0 / Chrome (live)

@AMBudnik
Copy link
Contributor

@AMBudnik AMBudnik commented Feb 21, 2020

Hey @mariomacedo

Please update to 7.4.2 and let us know if it works for you - the issue should be gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budnix budnix

Labels
Mobile Regression Status: Released Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@budnix @mariomacedo @AMBudnik @aninde