Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0.0-beta.2/8.0.0] Error in console when removing row or column when columnSummary is set #7174

Closed
aninde opened this issue Aug 6, 2020 · 3 comments
Assignees
Labels
bug Regression Issues that were created while adding new changes to the source code Status: Released Summary calculations Plugin

Comments

@aninde
Copy link
Contributor

aninde commented Aug 6, 2020

Description

Removing row or column when column summary is set with destinationRow and destinationColumn causes an error in the browser console

"Error: Assertion failed: Expecting an unsigned number." on

Screenshot 2020-08-06 at 14 12 22

function assert(condition, errorMessage) {
  if (!condition()) {
    throw new Error("Assertion failed: ".concat(errorMessage));

Steps to reproduce

  1. Remove any row or column.

Demo

https://jsfiddle.net/aninde/cs0e6g9d/ - v8.0.0-beta.2 (broken)
https://jsfiddle.net/aninde/w174k0su/ - v8.0.0 (broken)
https://jsfiddle.net/aninde/7qr4gtjo/ - v8.0.0-beta.1 (fixed)
https://jsfiddle.net/aninde/k3d2L6j9/ - v7.4.2 (fixed)

Your environment

  • Handsontable version: 8.0.0-beta.2 & 8.0.0
  • Browser Name and version: Firefox 79, Chrome 84
  • Operating System: macOS Catalina 10.15.6
@aninde aninde added bug Summary calculations Plugin Regression Issues that were created while adding new changes to the source code labels Aug 6, 2020
@AMBudnik
Copy link
Contributor

v8.0.0 example https://jsfiddle.net/zj6cuwm2/ works the same (ps. I've added numeric data to avoid NaN)

@wojciechczerniak wojciechczerniak added this to the September 2020 milestone Sep 1, 2020
@mrpiotr-dev mrpiotr-dev self-assigned this Sep 3, 2020
mrpiotr-dev added a commit that referenced this issue Sep 7, 2020
…de of ColumnSummary - it is no more possible to read the visual index of non-existing column/row
mrpiotr-dev pushed a commit that referenced this issue Sep 15, 2020
…de of ColumnSummary - it is no more possible to read the visual index of non-existing column/row (#7252)
@aninde
Copy link
Contributor Author

aninde commented Sep 28, 2020

This issue will be fixed by the upcoming v8.1.0 https://jsfiddle.net/aninde/cpgn51o9/.

@AMBudnik
Copy link
Contributor

AMBudnik commented Oct 1, 2020

Version 8.1.0 has just been released. We can close the issue, the regression is no longer replicable.

@AMBudnik AMBudnik closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Regression Issues that were created while adding new changes to the source code Status: Released Summary calculations Plugin
Projects
None yet
Development

No branches or pull requests

4 participants