Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trimming rows doesn't set correct table height #7241

Closed
feberhard opened this issue Sep 2, 2020 · 3 comments
Closed

Trimming rows doesn't set correct table height #7241

feberhard opened this issue Sep 2, 2020 · 3 comments

Comments

@feberhard
Copy link

Description

Trimming or hiding rows, when setting the table data through loadData(...) or updateSettings({ data: ... }) and having a fixed row and column, doesn't update the table height.
After a resize of the browser window, the table height is correct.
When setting the data immediately in new Handsontable(...) or when not using fixed rows and columns, the problem doesn't occur.

Steps to reproduce

  1. Have fixedRowsTop: 1, fixedColumnsLeft: 1
  2. Set data through loadData(...) or updateSettings({ data: ...})
  3. Trim rows
  4. Scrollbar still shows the height before the trimming

Demo

https://jsfiddle.net/t8qjd7k4/6/

Your environment

  • Handsontable version: 8.0.0
  • Browser Name and version: Chrome Version 85.0.4183.83 (Official Build) (64-bit)
  • Operating System: Windows 10 (2004)
@wojciechczerniak wojciechczerniak added this to the September 2020 milestone Sep 2, 2020
@AMBudnik
Copy link
Contributor

AMBudnik commented Sep 3, 2020

Thank you for sharing the issue report @feberhard

It looks like the data attachment time changes the situation

https://jsfiddle.net/AMBudnik/7d0yrbv1/

It works well in my demo, but when we use delay it breaks.

@jansiegel jansiegel self-assigned this Sep 22, 2020
jansiegel added a commit that referenced this issue Sep 24, 2020
- Remove the 'areElementSizesAdjusted' flag.�
- Add a test case for #7241
 (#7241)
jansiegel added a commit that referenced this issue Sep 24, 2020
jansiegel added a commit that referenced this issue Sep 29, 2020
…e()` calls. (#7286)

* - Remove the 'adjustElementsSize' calls from 'applyToDOM' methods.
- Remove the 'areElementSizesAdjusted' flag.�
- Add a test case for #7241
 (#7241)

* - Add a changelog entry.
 (#7241)
@aninde
Copy link
Contributor

aninde commented Nov 3, 2020

The upcoming v8.2.0 fixes this problem, scrollbar no longer appears after trim.
Demo v8.2.0 https://jsfiddle.net/aninde/cvqsn49k/

8 2 0

Tested on macOS Catalina 10.15.7

  • Chrome Beta 87 and stable 86
  • FF 83.0b7 and stable 82
  • Safari 14 and Safari Technology Prev 14.1

Windows 10

  • IE 11
  • Edge 86
  • Edge Dev 88
  • Chrome 86

@AMBudnik
Copy link
Contributor

Hi @feberhard @bamminger

We are happy to announce that the new version of Handsontable - 8.2.0 - that fixes this issue has been published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants