Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When we use RMB on a cell from the same row that the header the isSelectedByRowHeader value is not updated #7272

Closed
AMBudnik opened this issue Sep 14, 2020 · 2 comments

Comments

@AMBudnik
Copy link
Contributor

Description

When we use RMB on a cell from the same row that the header the isSelectedByRowHeader value is not updated.

Steps to reproduce

  1. Open the console
  2. Use RMB on 2 row header (index 1)
  3. Use RMB on cell F2

Result
You see 'Custom option 1' in the menu
Zrzut ekranu 2020-09-14 o 14 29 45

Expected result
You see 'No available options'
Zrzut ekranu 2020-09-14 o 14 30 24

You can see that it doesn't matter how many times you open the context menu for cells in the 2nd row (index 1) you always get true in the console as a result of the isSelectedByRowHeader() check.

Demo

https://jsfiddle.net/AMBudnik/3q0d2go5/ 8.0.0 (broken)
https://jsfiddle.net/AMBudnik/s4ua8mec/ 7.4.2 (broken)

Relates issues

Your environment

  • Handsontable version: Handsontable 8.0.0
  • Browser Name and version: Chrome 85
  • Operating System: macOS Catalina 10.15.6
@wojciechczerniak
Copy link
Contributor

Same as #7271, this is how the selection should work. When something is selected then RMB is not changing the selection. The context menu opens for the already selected range. Otherwise, it wouldn't be possible to open a context menu for a range, it would reset instantly to a single cell.

Won't fix.

@AMBudnik
Copy link
Contributor Author

Thank you for the clarification. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants