Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sorting by clickin the entire header #2167

Closed
wants to merge 1 commit into from

Conversation

TheLudd
Copy link

@TheLudd TheLudd commented Feb 17, 2015

This adds the class columnSorting to the div inside the table headers
which will allow the user to sort the columns by clicking the entire
header. Before this commit, the user was forced to click on the header
text for the sorting to take effect.

@TheLudd
Copy link
Author

TheLudd commented Feb 17, 2015

IMHO, being able to click the entire header to sort is a better user experience, therefore this change.

I only added one test to make sure that sorting actually works. The sorting plugin is already extensively tested and it seems unnecessary to duplicate all tests for this. All the previous tests still pass.

@AMBudnik
Copy link
Contributor

Great idea, let us take a closer look.

@TheLudd
Copy link
Author

TheLudd commented Mar 29, 2015

Just noticed that there was a merge conflict so I did a rebase. The conflict was in the files in the dist folder. I read in the contribution guidelines that I should edit files in the src directory and then do a build. Is this correct? I could just skip doing the build and there would have been no conflict.

This adds the class columnSorting to the div inside the table headers
which will allow the user to sort the columns by clicking the entire
header. Before this commit, the user was forced to click on the header
text for the sorting to take effect.
@krzysztofspilka krzysztofspilka modified the milestones: 0.15.0, 0.15.X May 5, 2015
@krzysztofspilka krzysztofspilka modified the milestones: 0.15.X, 0.15.0 May 5, 2015
@krzysztofspilka krzysztofspilka removed this from the 0.15.0 milestone May 22, 2015
@krzysztofspilka
Copy link
Member

I'm marking this one as a feature request as it demands a deep changes in the standard behaviour of our current sorting functionality.

To be found here: https://github.com/handsontable/handsontable/wiki/Feature-requests

@TheLudd
Copy link
Author

TheLudd commented May 27, 2015

@krzysztofspilka What is the deep change? Did the implementation I provided cause any problems?

@AMBudnik
Copy link
Contributor

AMBudnik commented May 10, 2021

I'm transferring this issue into a Github Discussion #7990. Please feel welcomed to share your comments and propositions on this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants