New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow sorting by clickin the entire header #2167
Conversation
IMHO, being able to click the entire header to sort is a better user experience, therefore this change. I only added one test to make sure that sorting actually works. The sorting plugin is already extensively tested and it seems unnecessary to duplicate all tests for this. All the previous tests still pass. |
d786683
to
12c1bcc
Compare
Great idea, let us take a closer look. |
12c1bcc
to
61523d6
Compare
Just noticed that there was a merge conflict so I did a rebase. The conflict was in the files in the |
61523d6
to
c68ffbc
Compare
c68ffbc
to
546eaaa
Compare
This adds the class columnSorting to the div inside the table headers which will allow the user to sort the columns by clicking the entire header. Before this commit, the user was forced to click on the header text for the sorting to take effect.
546eaaa
to
03841b8
Compare
I'm marking this one as a feature request as it demands a deep changes in the standard behaviour of our current sorting functionality. To be found here: https://github.com/handsontable/handsontable/wiki/Feature-requests |
@krzysztofspilka What is the deep change? Did the implementation I provided cause any problems? |
I'm transferring this issue into a Github Discussion #7990. Please feel welcomed to share your comments and propositions on this change. |
This adds the class columnSorting to the div inside the table headers
which will allow the user to sort the columns by clicking the entire
header. Before this commit, the user was forced to click on the header
text for the sorting to take effect.