Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typings for beforeColumnMove and beforeRowMove (#5416) #5425

Merged
merged 1 commit into from Oct 26, 2018
Merged

Fix typings for beforeColumnMove and beforeRowMove (#5416) #5425

merged 1 commit into from Oct 26, 2018

Conversation

guillaumep
Copy link
Contributor

Context

This is a fix for the TypeScript typings.

How has this been tested?

Through my own project which uses TypeScript.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. Wrong typing for beforeColumnMove #5416

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation.

@AMBudnik AMBudnik mentioned this pull request Oct 23, 2018
Closed
@pnowak pnowak self-requested a review October 26, 2018 11:55
@pnowak pnowak self-assigned this Oct 26, 2018
pnowak
pnowak approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@pnowak pnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pnowak pnowak merged commit 7374c2e into handsontable:develop Oct 26, 2018
@wojciechczerniak wojciechczerniak mentioned this pull request Feb 14, 2019
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnowak pnowak pnowak approved these changes

Assignees

@pnowak pnowak

Labels
CLA signed Status: Released TypeScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@guillaumep @pnowak @AMBudnik @gpratte-outbox