Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SelectEditor to ES6 #5618

Merged
merged 5 commits into from Dec 19, 2018

Conversation

Projects
None yet
3 participants
@swistach
Copy link
Member

swistach commented Nov 27, 2018

Context

Based on @aaronbeall's PR #5451 + added @jansiegel's suggestions.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Related issue(s):

  1. #5403

aaronbeall and others added some commits Nov 26, 2018

@swistach swistach added this to the December 2018 milestone Nov 27, 2018

@swistach swistach requested a review from jansiegel Nov 27, 2018

@wojciechczerniak wojciechczerniak referenced this pull request Nov 27, 2018

Closed

Refactor ES5 to ES6 code #5403

11 of 13 tasks complete
Show resolved Hide resolved src/editors/selectEditor.js Outdated
Show resolved Hide resolved src/editors/selectEditor.js Outdated
Show resolved Hide resolved src/editors/selectEditor.js

@jansiegel jansiegel assigned swistach and unassigned jansiegel Nov 28, 2018

swistach added some commits Dec 7, 2018

@swistach swistach assigned jansiegel and unassigned swistach Dec 7, 2018

@jansiegel jansiegel assigned swistach and unassigned jansiegel Dec 19, 2018

@swistach swistach merged commit 6d03df9 into develop Dec 19, 2018

4 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (budnix) No new issues
Details

@swistach swistach deleted the feature/selectEditorES6 branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.