Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TextEditor to ES6 #5646

Merged
merged 9 commits into from Dec 13, 2018

Conversation

Projects
None yet
4 participants
@swistach
Copy link
Member

swistach commented Dec 7, 2018

Context

Based on @aaronbeall's PR #5450 + added @jansiegel's suggestions.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Related issue(s):

  1. #5403
Convert TextEditor to ES6 class (#5450)
* Convert TextEditor to class syntax

* Fixed incorrect super call use of apply

@swistach swistach self-assigned this Dec 7, 2018

swistach added some commits Dec 7, 2018

@swistach swistach requested a review from jansiegel Dec 10, 2018

@swistach swistach assigned jansiegel and swistach and unassigned swistach and jansiegel Dec 10, 2018

@wojciechczerniak wojciechczerniak referenced this pull request Dec 11, 2018

Closed

Refactor ES5 to ES6 code #5403

11 of 13 tasks complete

@swistach swistach assigned jansiegel and unassigned swistach Dec 11, 2018

swistach added some commits Dec 12, 2018

@swistach swistach requested review from budnix and removed request for jansiegel Dec 13, 2018

@swistach swistach assigned budnix and unassigned jansiegel Dec 13, 2018

Show resolved Hide resolved src/editors/textEditor.js
Show resolved Hide resolved src/editors/textEditor.js Outdated

@budnix budnix assigned swistach and unassigned budnix Dec 13, 2018

swistach added some commits Dec 13, 2018

@swistach swistach assigned budnix and unassigned swistach Dec 13, 2018

@budnix

budnix approved these changes Dec 13, 2018

@budnix budnix assigned swistach and unassigned budnix Dec 13, 2018

@swistach swistach merged commit eeb81e1 into develop Dec 13, 2018

5 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (budnix) No new issues
Details
security/snyk - package.json (krzysztofspilka) No new issues
Details

@swistach swistach deleted the feature/textEditorES6 branch Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.