Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Walkontable.Event to ES6 #5655

Merged
merged 2 commits into from Dec 13, 2018

Conversation

Projects
None yet
2 participants
@swistach
Copy link
Member

swistach commented Dec 12, 2018

Context

Refactored Walkontable.Event to ES6 with necessary JSDocs annotation.

How has this been tested?

Everything should work as before.

Types of changes

  • Bug fix / Refactor (a non-breaking change which fixes an issue)

Related issue(s):

  1. #5403

swistach added some commits Dec 11, 2018

@swistach swistach requested a review from budnix Dec 12, 2018

@wojciechczerniak wojciechczerniak referenced this pull request Dec 12, 2018

Closed

Refactor ES5 to ES6 code #5403

11 of 13 tasks complete
@budnix

budnix approved these changes Dec 13, 2018

@budnix budnix assigned swistach and unassigned budnix Dec 13, 2018

@swistach swistach merged commit 2787b2d into develop Dec 13, 2018

5 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (budnix) No new issues
Details
security/snyk - package.json (krzysztofspilka) No new issues
Details

@swistach swistach deleted the feature/wotEventES6 branch Dec 13, 2018

budnix added a commit that referenced this pull request Dec 18, 2018

Refactor Walkontable.Event to ES6 (#5655)
* Refactor Walkontable.Event to ES6. WIP

* Added JSDocs + privatePool for private attributes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.