Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor editorManager to ES6 #5683

Merged
merged 4 commits into from Jan 8, 2019

Conversation

Projects
None yet
3 participants
@swistach
Copy link
Member

swistach commented Dec 18, 2018

Context

Refactored editorManager to ES6 with necessary JSDocs annotations.

How has this been tested?

Everything should work as before.

Types of changes

  • Bug fix / Refactor (a non-breaking change which fixes an issue)

Related issue(s):

  1. #5403

swistach added some commits Dec 17, 2018

@wojciechczerniak wojciechczerniak referenced this pull request Dec 19, 2018

Closed

Refactor ES5 to ES6 code #5403

11 of 13 tasks complete

@swistach swistach requested a review from wszymanski Dec 19, 2018

Show resolved Hide resolved src/editorManager.js Outdated
Show resolved Hide resolved src/editorManager.js Outdated
Show resolved Hide resolved src/editorManager.js Outdated
@wszymanski
Copy link
Member

wszymanski left a comment

Just minor remarks from me.

Show resolved Hide resolved src/editorManager.js Outdated
Show resolved Hide resolved src/editorManager.js Outdated
Show resolved Hide resolved src/editorManager.js Outdated
Show resolved Hide resolved src/editorManager.js Outdated
Show resolved Hide resolved src/editorManager.js Outdated
Show resolved Hide resolved src/editorManager.js Outdated
@wszymanski
Copy link
Member

wszymanski left a comment

A few more comments

@wszymanski wszymanski assigned swistach and unassigned wszymanski Jan 7, 2019

@swistach swistach requested a review from wszymanski Jan 7, 2019

@swistach swistach assigned wszymanski and unassigned swistach Jan 7, 2019

@wszymanski wszymanski self-requested a review Jan 8, 2019

@wszymanski wszymanski removed their assignment Jan 8, 2019

@wszymanski wszymanski assigned jansiegel and swistach and unassigned jansiegel Jan 8, 2019

@swistach swistach merged commit c93d607 into develop Jan 8, 2019

4 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (krzysztofspilka) No new issues
Details

@swistach swistach deleted the feature/editorManagerES6 branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.