Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TableView to ES6 #5690

Merged
merged 4 commits into from Jan 2, 2019

Conversation

Projects
None yet
2 participants
@swistach
Copy link
Member

swistach commented Dec 21, 2018

Context

Refactored TableView to ES6 with necessary JSDocs annotations.

How has this been tested?

Everything should work as before.

Types of changes

  • Bug fix / Refactor (a non-breaking change which fixes an issue)

Related issue(s):

  1. #5403

swistach added some commits Dec 20, 2018

@wojciechczerniak wojciechczerniak referenced this pull request Dec 21, 2018

Closed

Refactor ES5 to ES6 code #5403

12 of 13 tasks complete

@swistach swistach requested a review from budnix Dec 21, 2018

Show resolved Hide resolved src/tableView.js
Show resolved Hide resolved src/tableView.js Outdated
Show resolved Hide resolved src/helpers/mixed.js Outdated
Show resolved Hide resolved src/tableView.js
Show resolved Hide resolved src/helpers/mixed.js Outdated

@budnix budnix assigned swistach and unassigned budnix Dec 21, 2018

@swistach swistach assigned budnix and unassigned swistach Jan 2, 2019

@budnix

budnix approved these changes Jan 2, 2019

@budnix budnix assigned swistach and unassigned budnix Jan 2, 2019

@swistach swistach merged commit bc21538 into develop Jan 2, 2019

4 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (krzysztofspilka) No new issues
Details

@swistach swistach deleted the feature/tableViewES6 branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.