Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
bug fix: getCell returned "undefined" when it was expected to return -2 or -4 #6079
This PR fixes a blocking issue that I discovered while working on #6064
How has this been tested?
I added more assertions to the test of
However, it does not test
Types of changes
changed the title
bug fix: getCell returned "undefined" when it was expected to return …
Jul 2, 2019
I've reviewed the changes and it seems to be good. I added missing tests for mentioned methods and more. After syncing with develop branch there is a problem with UndoRedo plugin which fails in one test - this issue will be fixed in a separate branch.
I assigned @jansiegel to review my changes.