Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the definition file to keep alphabetical order #6159

Merged
merged 1 commit into from Jul 29, 2019
Merged

Update the definition file to keep alphabetical order #6159

merged 1 commit into from Jul 29, 2019

Conversation

AMBudnik
Copy link
Contributor

Context

Changed the order of options to keep alphabetical order. Moved numericFormat after noWordWrapClassName.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. The numericFormat option is not in the alphabetical order in the definition file #6158

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation.

@AMBudnik
Update the definition file
24c0943 
Changed the order of options to keep alphabetical order. Moved `numericFormat` after `noWordWrapClassName`.
@AMBudnik AMBudnik requested a review from pnowak July 29, 2019 09:48
pnowak
pnowak approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@pnowak pnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pnowak pnowak assigned AMBudnik and unassigned pnowak Jul 29, 2019
@AMBudnik AMBudnik merged commit 345782a into develop Jul 29, 2019
@AMBudnik AMBudnik deleted the feature/issue-6158 branch July 29, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnowak pnowak pnowak approved these changes

Assignees

@AMBudnik AMBudnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AMBudnik @pnowak