Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased width of div.forceScrollbar element in Handsontable.Dom tests. #6446

Merged
merged 1 commit into from Nov 12, 2019

Conversation

@swistach
Copy link
Contributor

swistach commented Nov 12, 2019

Context

An div.forceScrollbar element in Handsontable.Dom tests had only 4000px of its width. On wider screens it's not enough to generate scrollbar which is crucial to check correctness of: Handsontable.Dom > offset > left > should return offset left with position fixed & scrolled window

I decided to not use calculations (sum of real window.scrollLeft and left position) and increase default width and height of .forceScrollbar because In my opinion, it might help to catch potential regression / breaking changes in the future.

How has this been tested?

Run Handsontable.Dom > offset > left > should return offset left with position fixed & scrolled window spec on wider screen than 4000 (you can use Chrome DevTools to simulate wider viewport).

Types of changes

  • Bugfix (a non-breaking change which fixes an issue)
…4000px of width is not enough to generate scrollbar
@swistach swistach added this to the November 2019 milestone Nov 12, 2019
@swistach swistach requested a review from jansiegel Nov 12, 2019
@jansiegel jansiegel assigned swistach and unassigned jansiegel Nov 12, 2019
@swistach swistach merged commit 20c3af1 into develop Nov 12, 2019
4 checks passed
4 checks passed
continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (krzysztofspilka) No manifest changes detected
@swistach swistach deleted the fix-opera-offset-helper branch Nov 12, 2019
swistach added a commit that referenced this pull request Nov 12, 2019
…4000px of width is not enough to generate scrollbar (#6446)
swistach added a commit that referenced this pull request Nov 12, 2019
…4000px of width is not enough to generate scrollbar (#6446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.